Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced top and bottom shadow by background shadow 9patch #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

meesec
Copy link

@meesec meesec commented May 21, 2016

suggested fix for recent discussion around drag shadow.

@justasm
Copy link
Owner

justasm commented May 22, 2016

Nice! Thanks a lot, I like this solution. Would be interested to hear from @escobar5 if this solves #25.

Minor nitpicks:

  • The 9-patch shadow is a bit too dark imo, I think it may look nicer if the opacity was lower.
  • We should include a 9-patch for each of the common densities.

* The shadow to be drawn below the {@link #draggedItem}.
*/
private final Drawable dragBottomShadowDrawable;
private final Drawable dragShadowDrawable;
private final int dragShadowHeight;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to dragShadowMargin or similar.

@meesec
Copy link
Author

meesec commented May 22, 2016

updated.

i checked on an ldpi emulator, seems to work fine with the xxhdpi 9patch.

set alpha to 75 on the shadow. feel free to pick a different alpha.

@justasm
Copy link
Owner

justasm commented May 22, 2016

What did you use to generate the 9-patch?

@meesec
Copy link
Author

meesec commented May 22, 2016

A designer in my project build it a while ago. I assume sketch.

@escobar5
Copy link

thanks, I will check it as soon as I can

@daktarin
Copy link

How can I remove shadow when moving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants