把Alipay独有的配置从AuthConfig里提取出来 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice，建议很好！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthConfig从设计上看本应是公共的参数，但是实际上里面揉杂了各种第三方服务独有的配置。虽然文档已经解释得很清楚了，但是我觉得设计良好的代码应该具备更强的约束，所以对AuthConfig做了一些小修改。考虑到对旧版本的兼容性，我对不合理的属性和方法标记了@deprecated，并给出了注释说明
AuthChecker也存在相同的问题，作为一个工具类，它不应该了解任何AuthRequest的具体实现，否则check的逻辑在将来可能会无限膨胀
由于精力的关系，我暂时只处理了Alipay的第三方集成