Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'm getting a PHP warming message when the Hint exception is null #2

Closed
maxacarvalho opened this issue Jun 25, 2023 · 2 comments · Fixed by #3
Closed

I'm getting a PHP warming message when the Hint exception is null #2

maxacarvalho opened this issue Jun 25, 2023 · 2 comments · Fixed by #3
Assignees

Comments

@maxacarvalho
Copy link

Hi,

While developing locally, I have the PHP warnings enabled. I'm getting the following warning message because of that:

Exception: Warning: Attempt to read property "exception" on null in magento2/vendor/justbetter/magento2-sentry-filter-events/Observer/BeforeSending.php on line 33 in magento2/vendor/magento/framework/App/ErrorHandler.php:62

Is that expected to be null at that point?

@indykoning
Copy link
Member

While it shouldn't often be null it is certainly a possibility that Exception is null and it should be expected that it could be null

For instance the Exception will be missing if it is an event created because of a log.

As this is an issue within the magento2-sentry-filter-events package we'll transfer the issue there 🙂

@indykoning indykoning transferred this issue from justbetter/magento2-sentry Jun 26, 2023
@rbnmulder rbnmulder linked a pull request Jun 30, 2023 that will close this issue
@rbnmulder rbnmulder self-assigned this Jun 30, 2023
@indykoning
Copy link
Member

The fix has been released in version 1.0.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants