Check if there is a hint exception defined #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indykoning
reviewed
Jun 30, 2023
Observer/BeforeSending.php
Outdated
| $messages = $this->json->unserialize($this->scopeConfig->getValue('sentry/event_filtering/messages')); | ||
| foreach ($messages as $message) { | ||
| if (str_contains($hintMessage, $message['message'])) { | ||
| $observer->getEvent()->getSentryEvent()->unsEvent(); |
There was a problem hiding this comment.
Once we've unset the event there is no reason to keep looping, correct?
It may be a good idea to break out of the loop in that case 🙂
Suggested change
| $observer->getEvent()->getSentryEvent()->unsEvent(); | |
| $observer->getEvent()->getSentryEvent()->unsEvent(); | |
| break; |
Observer/BeforeSending.php
Outdated
Comment on lines
33
to
38
| if ($hint?->exception !== null) { | ||
| $hintMessage = $hint->exception->getMessage(); | ||
| if ($hint->exception instanceof LocalizedException) { | ||
| $hintMessage = $hint->exception->getRawMessage(); | ||
| $event->setMessage($hintMessage); | ||
| } |
There was a problem hiding this comment.
Aren't we able to get the message some other way when we do not have the exception, like getting it from the Event itself?
Then at least we will be able to continue to filter out events even without hint.
Suggested change
| if ($hint?->exception !== null) { | |
| $hintMessage = $hint->exception->getMessage(); | |
| if ($hint->exception instanceof LocalizedException) { | |
| $hintMessage = $hint->exception->getRawMessage(); | |
| $event->setMessage($hintMessage); | |
| } | |
| $hintMessage = $hint?->exception?->getMessage() ?? $event->getMessage(); | |
| if ($hint?->exception instanceof LocalizedException) { | |
| $hintMessage = $hint->exception->getRawMessage() ; | |
| $event->setMessage($hintMessage); | |
| } |
Otherwise i would suggest flipping the logic of the if and returning early to reduct the depth of if/else
Suggested change
| if ($hint?->exception !== null) { | |
| $hintMessage = $hint->exception->getMessage(); | |
| if ($hint->exception instanceof LocalizedException) { | |
| $hintMessage = $hint->exception->getRawMessage(); | |
| $event->setMessage($hintMessage); | |
| } | |
| if ($hint?->exception === null) { | |
| return | |
| } | |
| $hintMessage = $hint->exception->getMessage(); | |
| if ($hint->exception instanceof LocalizedException) { | |
| $hintMessage = $hint->exception->getRawMessage(); | |
| $event->setMessage($hintMessage); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.