Set Exception Value and Message of Event #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indykoning
reviewed
Jul 26, 2023
| @@ -34,6 +34,8 @@ public function execute(Observer $observer): void | |||
| if ($hint?->exception instanceof LocalizedException) { | |||
| $hintMessage = $hint->exception->getRawMessage(); | |||
| $event->setMessage($hintMessage); | |||
| $event->getExceptions()[0]->setValue($hintMessage); | |||
There was a problem hiding this comment.
It may be a good idea to check if this index exists
There was a problem hiding this comment.
@indykoning There should be at least one exception in the array. Sentry prepares the event and does the following checks before setting the exceptions on the event: https://github.com/getsentry/sentry-php/blob/master/src/Client.php#L244 and https://github.com/getsentry/sentry-php/blob/master/src/Client.php#L415C22-L415C41
I can add the check for the index to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event message was not properly returned and I also updated the exception value since that was still localized and could give the wrong message in Sentry.
Updating the exception value was based on feedback from getsentry/sentry-javascript#3204