fix EvilPortal for board setups without SD #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a check for the HAS_SD definition to the setHtml & setAP functions respectively.
tracedgod
changed the title
S-Ali-Zaidi
approved these changes
Feb 15, 2024
|
Tried this and it fixed he issue I was having. Looks good to me! |
|
looks good to me. Fixed the issue. (Lilygo T-Beam) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check for the
HAS_SDdefinition to thesetHtml&setAPfunctions respectively.Without these changes, compilation fails due to the configuration not having an
sd_objreference.Looks to be similar / identical to #479, minus a new board configuration being added in that PR.