v2.11.0 - Add geo related icons. #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 32 32
Branches 3 3
=========================================
Hits 32 32 Continue to review full report at Codecov.
|
matthewhardern
approved these changes
Nov 25, 2020
simonsandersje
approved these changes
Nov 25, 2020
ashleynolan
reviewed
Nov 25, 2020
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 18 18"><path d="M.713 8.903c-.122-.153-.275-.337-.275-.52-.061-.398.184-.796.52-.918L16.348.489a.86.86 0 01.95.214.86.86 0 01.213.948l-6.915 15.39c-.122.337-.52.582-.918.521a.951.951 0 01-.795-.704l-1.224-6.456-6.456-1.224c-.184-.091-.367-.153-.49-.275zm8.66-.214l.703 5.324 5.14-11.168L3.499 7.863l5.874.826z" fill="#266ABD"/></svg> | |||
There was a problem hiding this comment.
QQ – we usually add all icons in as black and then style the fill to keep them consistent. Could I be a pain and ask that we do the same here?
There was a problem hiding this comment.
Yeah I was unsure about that. Can i pick this up after i finish adding the icon into f-searchbox? I'll come back and redo it then update searchbox in a follow up PR (after the one im currently working on)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added