feat(browserslist-config-pie): DSW-31 add initial browserslist package and config #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xander-marjoram
added
work-in-progress
🦋 Changeset detectedLatest commit: 7074d4c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
xander-marjoram
force-pushed
the
dsw-31-browserslist
branch
from
e9366e3 to
7c4bd8e
Compare
xander-marjoram
removed
work-in-progress
webbertakken
approved these changes
Sep 29, 2023
maledr5
approved these changes
Oct 2, 2023
xander-marjoram
added
approved-1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
You can see how the browserslist config resolves here: https://browsersl.ist/#q=last+3+Chrome+versions%0Alast+3+ChromeAndroid+versions%0Alast+4+iOS+major+versions%0Alast+4+Safari+major+versions%0Alast+4+Firefox+versions%0Alast+4+Edge+versions%0Alast+3+Samsung+versions
Note: there seems to be a long-standing caniuse bug where only the latest version of ChromeAndroid is returned. See here for more: browserslist/browserslist#156
Author Checklist (complete before requesting a review)
PIE Docschange, I have reviewed the Docs site previewReviewer checklists (complete before approving)
Reviewer 1
PIE Docschange, I have reviewed the PR previewReviewer 2
PIE Docschange, I have reviewed the PR preview