Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets can now be mounted on a custom path #5

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

goncalo-oliveira
Copy link
Contributor

By providing an annotation, it's now possible to customize the path where secrets are mapped to in the function's container. The default behaviour does not change.

apiVersion: justfaas.com/v1alpha1
kind: Function
metadata:
  name: hello
  namespace: default
  annotations:
    justfaas.com/secrets-mount-path: /app/secrets
spec:
  image: gcr.io/google-samples/hello-app:1.0
  secrets:
    - my-secret

The above will mount the function's secrets at /app/secrets as annotated.

@goncalo-oliveira goncalo-oliveira linked an issue Aug 7, 2023 that may be closed by this pull request
@goncalo-oliveira goncalo-oliveira merged commit 316a883 into main Aug 7, 2023
1 check passed
@goncalo-oliveira goncalo-oliveira deleted the 4-secrets-mount-path branch August 7, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Mount secrets to a custom path
1 participant