Allow client package override #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I'll have to do some testing of this to make sure it works as expected under Ubuntu/Debian as well. |
|
@ghola Please do some syntax cleanup for the variables to conform to Puppet style specifications and I'll accept/close this pull request. Thanks. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent VM build (centos 6.6) i noticed that the memcached and couchbase client libraries conflict. They are both using libevent, but while memcached is using the standard centos repo libevent, couchbase is using libcouchbase2-libevent from the couchbase repo.
It turns out that couchbase can also use libcouchbase2-libev and this solves the conflict with memcached. But to do that one needs to be able to override the default client_package, hence this PR.