Fix range to be sensible given the unit #155
Conversation
WalkthroughThe pull request focuses on updating the README.md for the Automatic Cohort Extraction System (ACES). The changes enhance documentation clarity, update library version support for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
206-215: LGTM! The SpO2 range correction improves medical accuracy.The change from 120 to 100 as the maximum value for SpO2 is correct since oxygen saturation is measured as a percentage and cannot exceed 100%. This makes the documentation more accurate and helps users better understand how to handle potential outliers in their data.
Consider adding a note explaining that values above 100% should be treated as measurement errors or noise in the data preprocessing step.
normal_spo2: code: lab//O2 saturation pulseoxymetry (%) # required <str>//<str> value_min: 90 # optional <float/int> value_max: 100 # optional <float/int> value_min_inclusive: true # optional <bool> value_max_inclusive: true # optional <bool> other_cols: {} # optional <dict> + # Note: SpO2 values above 100% should be treated as measurement errors + # or noise during data preprocessing.
|
Thank you for catching this! |
Tiny fix in the docs here,
SpO2values measured in%should never be above 100 (it's a percentage). If they are, this should be dealth with somewhere else as noise, outliers, etc.Summary by CodeRabbit
polarsandMEDS.