Skip to content
This repository has been archived by the owner on Jun 17, 2023. It is now read-only.

lint configs should be relative to repo root #31

Closed
justinabrahms opened this issue Jan 19, 2014 · 8 comments · Fixed by #39
Closed

lint configs should be relative to repo root #31

justinabrahms opened this issue Jan 19, 2014 · 8 comments · Fixed by #39
Assignees

Comments

@justinabrahms
Copy link
Owner

right now, you have to specify them relative to where you run it, which is silly.

@scottjab
Copy link
Collaborator

How do we want to handle this? Maybe .imhotep-pluginname.conf at the root of a repo?

@justinabrahms
Copy link
Owner Author

Ahh. Maybe. I was actually thinking this meant "hey, go look for my
.jshintrc file at the root of my repo".
On Jan 21, 2014 2:28 PM, "James Scott" notifications@github.com wrote:

How do we want to handle this? Maybe .imhotep-.conf at the root of a repo?


Reply to this email directly or view it on GitHubhttps://github.com//issues/31#issuecomment-32971420
.

@scottjab
Copy link
Collaborator

A few of the linters actually support this natively, but I would like to provide an override method. We can inspect the names of the classes and look for files that match the name of the classes in a checked out repo. I can pass a kwarg that has a absolute path to a config file to the tool. It should not break existing modules.

@justinabrahms
Copy link
Owner Author

@scottjab can you provide a link to one?

@scottjab
Copy link
Collaborator

https://github.com/bbatsov/rubocop supports an override.

@justinabrahms
Copy link
Owner Author

Ahh, yes. Most do, but our tools don't yet pass them (or discern if they're
there), which is what this ticket tracks. :)
On Jan 24, 2014 12:42 PM, "James Scott" notifications@github.com wrote:

https://github.com/bbatsov/rubocop supports an override.


Reply to this email directly or view it on GitHubhttps://github.com//issues/31#issuecomment-33253981
.

@scottjab
Copy link
Collaborator

I think I will take a crack at this tomorrow at pyladies.

@justinabrahms
Copy link
Owner Author

Awesome. Thanks. This is the last big ticket for me, FYI.
On Jan 24, 2014 4:11 PM, "James Scott" notifications@github.com wrote:

I think I will take a crack at this tomorrow at pyladies.


Reply to this email directly or view it on GitHubhttps://github.com//issues/31#issuecomment-33270852
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants