-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/supercharger #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--Removed line and char from the grapheme iterator result to prevent cloning u32's on each iteration
justinwilaby
added
enhancement
New feature or request
Documentation
Documentation correctness/thouroughness issue
labels
Jan 16, 2025
justinwilaby
force-pushed
the
feature/supercharger
branch
from
January 16, 2025 16:41
5d1c5b6
to
9b6832b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3x increase in speed - Major speed improvement
Drastic increase in performance over previous versions - both in speed and memory consumption
u8
) instead ofString
types in Rust eliminating Rust's internal grapheme boundary and broken surrogate checks (these are handled by sax-wasm at a low level)Breaking changes
toJSON()
is called on the dispatched object. WASM data associated with eachTag
,Attribute
,ProcInst
andText
objects received from the parsing operation have a 'lifetime' that is limited to theeventHandler()
or the generator function loop body for*parse()
.eventHandler()
or*parse()
operation, use the object returned from thetoJSON()
function.eventHandler()
or*parse()
operation and need to calltoJSON()
otherwise, this is not needed.toJSON()
calls.