Skip to content

Conversation

Dretch
Copy link
Contributor

@Dretch Dretch commented Oct 9, 2018

Can closeDB return an Aff?

This would mean API users have to do less converting between Aff and Effect

@Dretch
Copy link
Contributor Author

Dretch commented Oct 9, 2018

Hmmm, my proposed change is not safe: the cb function needs to be called, otherwise the closeDB call will never complete.

The original closeDB using Effect is also not safe, though, since it won't wait for the close to actually complete.

I'll change this.

@Dretch
Copy link
Contributor Author

Dretch commented Oct 10, 2018

I think this is good now. Please consider this change!

@Dretch
Copy link
Contributor Author

Dretch commented Oct 21, 2018

Bump @justinwoo 🙏

@justinwoo
Copy link
Owner

Oh, sorry. Looks good, maybe eventually could use a closeDB' or something for the Effect version.

@justinwoo justinwoo merged commit 0fb2399 into master Oct 21, 2018
@justinwoo justinwoo deleted the close-with-aff branch October 21, 2018 19:21
@justinwoo
Copy link
Owner

Made https://github.com/justinwoo/purescript-node-sqlite3/releases/tag/v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants