Change from Param = String to Param = Foreign. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to allow passing Node Buffer objects as params.
|
Oh, right. Yeah, params should always have been Foreign, just that I was lazy about it |
justinwoo
approved these changes
Nov 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to allow passing Node
Bufferobjects as params.One downside is that this arguably makes the API even less type-safe, but at least it also makes the parameter types more consistent with the query return type (
Array Foreign).Right now I have a type-safe API at a higher level (in
purescript-querydsl), but I guesspurescript-node-sqlite3could have a type-safe API too.