Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizations #290

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Optimizations #290

merged 7 commits into from
Nov 14, 2023

Conversation

justkawal
Copy link
Owner

@justkawal justkawal commented Nov 14, 2023 •
edited by FauconSpartiate
Loading

  • Few tweaks and optimizations for excel processing heavy data.
    • Now instead of 1 minutes 7 seconds for 20,000 cells it takes ----> 0.2 seconds for 20,000 cells
    • For 10,00,000 it takes ---> ( near to 8 ) seconds only.

Fixes #262, Fixes #289

Any more changes and optimizations are welcomed.
Thanks.

@justkawal justkawal added the enhancement New feature or request label Nov 14, 2023
FauconSpartiate
FauconSpartiate approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@FauconSpartiate FauconSpartiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

335 000% perf improvement? 👀👀👀
LGTM

@FauconSpartiate FauconSpartiate merged commit 4d61ab0 into main Nov 14, 2023
1 check passed
@FauconSpartiate FauconSpartiate deleted the justkawal/optimizations branch November 14, 2023 06:44
@FauconSpartiate FauconSpartiate mentioned this pull request Nov 14, 2023
Closed
@tim1mmr tim1mmr mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FauconSpartiate FauconSpartiate FauconSpartiate approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excel slows down on saving heavy data. Reading larger xlsx files is too slow
2 participants
@justkawal @FauconSpartiate