-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse column width and row height #347
Parse column width and row height #347
Conversation
@DavidPoetsch Tests ensure everything works as expected, and does not get broken in future updates. |
@DavidPoetsch Make sure to run Edit: The command is |
Sry i do not understand. How will it change the formatting? Where can i run this? Furthermore, why are checks failing? |
Sorry the right command is The online checks are sometimes broken, I reran them and now they're passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work
Changed the parse.dart to solve the issue where column widths and row heights are not parsed.
Fixes #277, #238
I solved it by adding a new function to the Parser class.
and i called the function in the _parseTable function right after _parseHeaderFooter: