Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich text #358

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Rich text #358

merged 3 commits into from
Jul 9, 2024

Conversation

TarekTolba1
Copy link
Contributor

@TarekTolba1 TarekTolba1 commented Jul 9, 2024 •
edited by FauconSpartiate
Loading

This is a fork from #354 with tests added as @FauconSpartiate purposed.

Implements Rich Text #320

TextCellValue uses a new TextSpan instead of a just String. It's similar to the one from Flutter, using CellStyle (even if only a few values can be changed)

SharedString has a new textSpan property that parses the String Item (si) node and creates the TextSpan according to the Run Properties (rPr).

Fixes #320, #354

FauconSpartiate
FauconSpartiate approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@FauconSpartiate FauconSpartiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FauconSpartiate FauconSpartiate merged commit 6880d95 into justkawal:main Jul 9, 2024
1 check passed
@FauconSpartiate FauconSpartiate mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FauconSpartiate FauconSpartiate FauconSpartiate approved these changes

@justkawal justkawal Awaiting requested review from justkawal justkawal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rich Text
3 participants
@TarekTolba1 @FauconSpartiate @luizgpa