Fixed constraint default property value retrieval #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of constraint definitions
Comment on lines
+136
to
+141
| if (isConstraintDefinition(currentNode)) { | ||
| metaInf = getOrFailMetaInformation(currentNode.type); | ||
| } else { | ||
| assert(isReference(currentNode.type)); | ||
| metaInf = getOrFailMetaInformation(currentNode.type); | ||
| } |
There was a problem hiding this comment.
Can u do sth like
if (isBlockDefinition(currentNode)) {
assert(isReference(currentNode.type);
}
const metaInf = getOrFailMetaInformatin(currentNode.type);
Would be a little easier to read.
There was a problem hiding this comment.
That unfortunately does not work, because it would require a declaration of the following type: getOrFailMetaInformation(type: Reference<BuiltinBlocktypeDefinition> | ConstraintTypeLiteral)
The reason being that Typescript is unable to detect multiple declarations and decide which one to use.
georg-schwarz
deleted the
bugfix/constraints-get-default-property-value
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue that prevented the retrieval of default property values of constraint definitions