Modified MousePressed and MouseReleased action to catch all clicks #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…even if they occur within one frame) are caught.
|
Nevermind, found a few bugs to iron out yet with this implementation. |
|
Ok, I fixed those bugs and tested more thoroughly. Should be good to go! |
| io.MousePos = ImVec2((float)ofGetMouseX(), (float)ofGetMouseY()); | ||
| for(int i = 0; i < 5; i++){ | ||
| io.MouseDown[i] = engine->mousePressed[i]; | ||
| engine->mousePressed[i] = engine->mouseDragged || false; // Don't set to false if the mouse is being dragged |
There was a problem hiding this comment.
Does this do the same thing? Seems to me that false by itself will always evaluate to true
if(engine->mouseDragged)
{
engine->mousePressed[i] = true;
}else
{
engine->mousePressed[i] = false;
}
There was a problem hiding this comment.
Yeah - A more concise form would be
engine->mousePressed[i] = engine->mouseDragged
|
Found bug when vSync was turned off. |
|
By changing the strategy ever so slightly to track when the mouse was released, the bug with vSync = FALSE has been resolved. |
|
I'm going to move the pull request to a branch other than master |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the ImGui code and examples, I discovered that their code does not set io.MouseDown to false when the mouse is released. Instead, io.MouseDown is set to false one frame later. I've implemented a solution very similar to the ImGui example code; this resolves #37.