Skip to content

Commit

Permalink
github-actions/pnl-ci-docs: Only remove zero tag if it was successful…
Browse files Browse the repository at this point in the history
…ly added

This avoids cascading error if the workload fails before the tag was
added.

Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
  • Loading branch information
jvesely committed Apr 20, 2022
1 parent be02cf5 commit c628be1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/pnl-ci-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ jobs:
# set it to a fixed value to prevent polluting the diff
# This needs to be done after installing PNL
# to not interfere with dependency resolving
id: add_zero_tag
if: github.event_name == 'pull_request'
run: git tag --force 'v0.0.0.0'

Expand All @@ -105,7 +106,7 @@ jobs:
- name: Remove git tag
# The generated docs include PNL version,
# This was set to a fixed value to prevent polluting the diff
if: github.event_name == 'pull_request' && always()
if: steps.add_zero_tag.conclusion == 'success'
run: git tag -d 'v0.0.0.0'

- name: Upload Documentation
Expand Down

0 comments on commit c628be1

Please sign in to comment.