Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jsesc dependency #141

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

nmcdaines
Copy link
Contributor

The current version of jsesc has an incorrect license field in the package.json that was corrected in a later release so would be nice to update to the newer version.

@nicolo-ribaudo
Copy link
Collaborator

What are the breaking changes from 0.5 to 3.0?

@nmcdaines
Copy link
Contributor Author

Hi @nicolo-ribaudo,
I appreciate the quick response 🙏

From a cursory look over the commit history; I am not sure the specifics of why they have bumped major commits;

Otherwise I think the main changes are removing support for older versions, see the following statement from the package README.md

As of v3.0.0, jsesc supports Node.js v6+ only.

Older versions (up to jsesc v1.3.0) support Chrome 27, Firefox 3, Safari 4, Opera 10, IE 6, Node.js v6.0.0, Narwhal 0.3.2, RingoJS 0.8-0.11, PhantomJS 1.9.0, and Rhino 1.7RC4. Note: Using the json option on objects or arrays that contain non-string values relies on JSON.parse(). For legacy environments like IE ≤ 7, use a JSON polyfill.
https://github.com/mathiasbynens/jsesc?tab=readme-ov-file#support

Hope that helps 🙂

Copy link
Collaborator

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me then :)

@jviereck jviereck merged commit 49741a3 into jviereck:gh-pages Sep 16, 2024
@jviereck
Copy link
Owner

Thanks @nmcdaines for the contribution and @nicolo-ribaudo for your comments and approval!

@nmcdaines
Copy link
Contributor Author

Thanks soo much guys, I really appreciate your help 🙏

@JLHwung
Copy link
Collaborator

JLHwung commented Sep 17, 2024

@jviereck Could you do an npm release? Thank you.

@jviereck
Copy link
Owner

Should be able to do a npm release later this evening (I am in New York).

@jviereck
Copy link
Owner

Published npm release: https://www.npmjs.com/package/regjsparser

Release version on GitHub: https://github.com/jviereck/regjsparser/releases/tag/v0.11.0

Feels good to be able to do open source again! Let me know if there is anything else :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants