-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade jsesc dependency #141
upgrade jsesc dependency #141
Conversation
What are the breaking changes from 0.5 to 3.0? |
Hi @nicolo-ribaudo, From a cursory look over the commit history; I am not sure the specifics of why they have bumped major commits;
Otherwise I think the main changes are removing support for older versions, see the following statement from the package README.md
Hope that helps 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me then :)
Thanks @nmcdaines for the contribution and @nicolo-ribaudo for your comments and approval! |
Thanks soo much guys, I really appreciate your help 🙏 |
@jviereck Could you do an npm release? Thank you. |
Should be able to do a npm release later this evening (I am in New York). |
Published npm release: https://www.npmjs.com/package/regjsparser Release version on GitHub: https://github.com/jviereck/regjsparser/releases/tag/v0.11.0 Feels good to be able to do open source again! Let me know if there is anything else :) |
The current version of
jsesc
has an incorrectlicense
field in thepackage.json
that was corrected in a later release so would be nice to update to the newer version.