v0.5.1: Fixing localStorage backend's compatibility with non-BFS Buff…

…ers. Fallback to base64 encoding when binary_string isn't available.
jvilk · Nov 7, 2015 · c8ff260 · c8ff260
1 parent b35d82a
commit c8ff260
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-# BrowserFS v0.5.0
+# BrowserFS v0.5.1
 > BrowserFS is an in-browser file system that emulates the [Node JS file system API](http://nodejs.org/api/fs.html) and supports storing and retrieving files from various backends. BrowserFS also integrates nicely into the Emscripten file system.
 
 [![NPM version](https://badge.fury.io/js/browserfs.svg)](http://badge.fury.io/js/browserfs)

diff --git a/dist/browserfs.js b/dist/browserfs.js
@@ -8549,6 +8549,9 @@ catch (e) {
     supportsBinaryString = false;
 }
 binaryEncoding = supportsBinaryString ? 'binary_string' : 'binary_string_ie';
+if (!Buffer.isEncoding(binaryEncoding)) {
+    binaryEncoding = "base64";
+}
 var LocalStorageStore = (function () {
     function LocalStorageStore() {
     }

diff --git a/dist/browserfs.js.map b/dist/browserfs.js.map
diff --git a/dist/browserfs.min.js b/dist/browserfs.min.js
diff --git a/dist/browserfs.min.js.map b/dist/browserfs.min.js.map
diff --git a/dist/node/backend/LocalStorage.js b/dist/node/backend/LocalStorage.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "browserfs",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "A filesystem in your browser!",
   "main": "dist/browserfs.js",
   "typings": "dist/node/main",

diff --git a/src/backend/LocalStorage.ts b/src/backend/LocalStorage.ts
@@ -15,7 +15,11 @@ try {
   supportsBinaryString = false;
 }
 binaryEncoding = supportsBinaryString ? 'binary_string' : 'binary_string_ie';
-
+if (!Buffer.isEncoding(binaryEncoding)) {
+  // Fallback for non BrowserFS implementations of buffer that lack a
+  // binary_string format.
+  binaryEncoding = "base64";
+}
 
 /**
  * A synchronous key-value store backed by localStorage.