Lock generator refactoring #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces an internal `PackageAnnotations` struct that collects things like build dependencies, ignored dependencies, etc. prior to constructing PackageTargets. This cleans up the prior messiness that existed due to PackageTarget objects being modified after construction to apply these options. The primary driver behind this change was to push the handling of ignored dependencies to a deeper layer, so that we don't generate wheel/sdist repos and other artifacts for packages that are completely ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an internal
PackageAnnotationsstruct that collects things likebuild dependencies, ignored dependencies, etc. prior to constructing PackageTargets.
This cleans up the prior messiness that existed due to PackageTarget objects being
modified after construction to apply these options.
The primary driver behind this change was to push the handling of ignored dependencies
to a deeper layer, so that we don't generate wheel/sdist repos and other artifacts for
packages that are completely ignored.
Also, allow empty
python_compatible_withandflagslists to fix a regression introduced in #51.