fix: pdm translator fails to resolve dependency if pre-release version is required #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvolkman
reviewed
Dec 7, 2023
Comment on lines
85
to
86
| if not req.specifier: | ||
| return True |
There was a problem hiding this comment.
Did you verify that this actually resolves the issue? req.specifier is already supposed to behave this way when no specifier is present, so I think something else might be going on.
E.g.
>>> from packaging.requirements import Requirement
>>> from packaging.version import Version
>>> req = Requirement("foo")
>>> ver = Version("1.0")
>>> print(f"spec={req.specifier}")
spec=
>>> print(req.specifier.contains(ver))
True
There was a problem hiding this comment.
I'll try to provide a repro tomorrow
There was a problem hiding this comment.
hm. you're right. i cant seem to easily reproduce this.
need some time to investigate.
will post back
There was a problem hiding this comment.
min-repro is pdm add furo.
which pulls in sphinx-basic-ng without a contraint, which resolves to 1.0.0b1..
and then basically this happens:
>>> from packaging.requirements import Requirement
>>> from packaging.version import Version
>>>
>>> req = Requirement("sphinx-basic-ng")
>>> ver = Version("1.0.0b1")
>>> print(f"spec={req.specifier}")
spec=
>>> print(req.specifier.contains(ver))
False
There was a problem hiding this comment.
so it's basically about using prereleases=True for Specifier.contains
betaboon
force-pushed
the
fix-pdm-resolve-without-spec
branch
from
33441f8 to
1ac2897
Compare
betaboon
force-pushed
the
fix-pdm-resolve-without-spec
branch
from
1ac2897 to
ac1a627
Compare
betaboon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
__main__.MismatchedVersionException: Found no packages to satisfy dependency (name=sphinx-basic-ng, spec=)which occurs if a package does not specify any constraints for a dependency.