-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for debian bullseye #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding Debian support! I like the progress however there is one item to address that is breaking installation on other distributions.
I'm also adding some more variables to have |
my local molecule fails at
do you use it for test or you moved to github actions fro testing? |
I also have had a lot of problems with I have been relying more on testing during the PR checks or manually with a test VM but I too wish I could rely on local molecule testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are getting closer. There is a potential order of operations issue that is causing some of the builds to fail (see review comments).
Feel free to add the appropriate Debian distros the GitHub actions matrices to include in testing if you like. Otherwise I will be adding them at the completion of this PR to ensure we do not break it in the future.
I'm sorry for this trial and error approach but without proper testing, i' just trying... |
It's no problem at all! This is what PRs are for. Feel free to send as many commits as you need. |
I moved my local molecule testing on a amd64 machine and I'm using molecule-vagrant. For example, debian 10 (on python 3.7) gets a warning from netbox 3.11 that will not be supported in the future. this is interpreted as a non zero by ansible and fails the task. |
Add support for Debian bullseye, which doesn't have python3.8 (only 3.9).
Bumped ansible-role-postgresql version in molecule if we want at some point add debian in tests. This version comes with support for Debian-11.
Feel free to modify the code to adapt to your coding style.