Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for debian bullseye #28

Merged
merged 9 commits into from
Apr 27, 2022
Merged

add support for debian bullseye #28

merged 9 commits into from
Apr 27, 2022

Conversation

duviful
Copy link
Contributor

@duviful duviful commented Apr 7, 2022

Add support for Debian bullseye, which doesn't have python3.8 (only 3.9).
Bumped ansible-role-postgresql version in molecule if we want at some point add debian in tests. This version comes with support for Debian-11.

Feel free to modify the code to adapt to your coding style.

Copy link
Owner

@jvoss jvoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding Debian support! I like the progress however there is one item to address that is breaking installation on other distributions.

tasks/variables.yml Show resolved Hide resolved
tasks/variables.yml Show resolved Hide resolved
@duviful
Copy link
Contributor Author

duviful commented Apr 7, 2022

I'm also adding some more variables to have tasks/upgrade.yml properly working with the changes I've introduced.

@duviful
Copy link
Contributor Author

duviful commented Apr 7, 2022

my local molecule fails at

TASK [geerlingguy.postgresql : Ensure PostgreSQL is started and enabled on boot.] ***
fatal: [instance]: FAILED! => {"changed": false, "cmd": "/bin/systemctl", "msg": "Failed to connect to bus: No such file or directory", "rc": 1, "stderr": "Failed to connect to bus: No such file or directory\n", "stderr_lines": ["Failed to connect to bus: No such file or directory"], "stdout": "", "stdout_lines": []}

do you use it for test or you moved to github actions fro testing?

@duviful duviful requested a review from jvoss April 7, 2022 13:27
@jvoss
Copy link
Owner

jvoss commented Apr 7, 2022

my local molecule fails at

TASK [geerlingguy.postgresql : Ensure PostgreSQL is started and enabled on boot.] ***
fatal: [instance]: FAILED! => {"changed": false, "cmd": "/bin/systemctl", "msg": "Failed to connect to bus: No such file or directory", "rc": 1, "stderr": "Failed to connect to bus: No such file or directory\n", "stderr_lines": ["Failed to connect to bus: No such file or directory"], "stdout": "", "stdout_lines": []}

do you use it for test or you moved to github actions fro testing?

I also have had a lot of problems with geerlingguy.postgresql for local testing as well, at least on OSX. I'm curious if developing on Linux has the same issue considering the GitHub actions run fine.

I have been relying more on testing during the PR checks or manually with a test VM but I too wish I could rely on local molecule testing.

@jvoss jvoss added the enhancement New feature or request label Apr 7, 2022
Copy link
Owner

@jvoss jvoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are getting closer. There is a potential order of operations issue that is causing some of the builds to fail (see review comments).

Feel free to add the appropriate Debian distros the GitHub actions matrices to include in testing if you like. Otherwise I will be adding them at the completion of this PR to ensure we do not break it in the future.

vars/Amazon-2.yml Outdated Show resolved Hide resolved
vars/Debian-10.yml Outdated Show resolved Hide resolved
vars/Debian-11.yml Outdated Show resolved Hide resolved
vars/RedHat-8.yml Outdated Show resolved Hide resolved
vars/Ubuntu-20.yml Outdated Show resolved Hide resolved
@duviful
Copy link
Contributor Author

duviful commented Apr 11, 2022

I'm sorry for this trial and error approach but without proper testing, i' just trying...

@jvoss
Copy link
Owner

jvoss commented Apr 11, 2022

I'm sorry for this trial and error approach but without proper testing, i' just trying...

It's no problem at all! This is what PRs are for. Feel free to send as many commits as you need.

@duviful
Copy link
Contributor Author

duviful commented Apr 14, 2022

I moved my local molecule testing on a amd64 machine and I'm using molecule-vagrant.
I added boxes for all the OS flavors.
I still got some non-zero return codes during configure.py to sort out.

For example, debian 10 (on python 3.7) gets a warning from netbox 3.11 that will not be supported in the future. this is interpreted as a non zero by ansible and fails the task.

vars/Amazon-2.yml Outdated Show resolved Hide resolved
tasks/install.amazon.yml Show resolved Hide resolved
tasks/install.amazon.yml Show resolved Hide resolved
@jvoss jvoss merged commit 5472923 into jvoss:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants