Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fedora37 #57

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Add fedora37 #57

merged 7 commits into from
Apr 26, 2023

Conversation

johanneskastl
Copy link
Contributor

Add Fedora37 variables and adjust loading of variables.

Loading the variables is not really nice, since the existing code uses ansible_os_family == "RedHat", which also matches Fedora. If desired I could rework that to use e.g. first_found or similar.

jvoss
jvoss previously approved these changes Apr 22, 2023
@jvoss
Copy link
Owner

jvoss commented Apr 23, 2023

Updated the testing and documentation to include Fedora 37. However the checks seem to be failing on the installation step where the upgrade.sh netbox script is ran:

"Failed to build Pillow"

Are there any additional Python packages or steps for Fedora that need to be added to make this work on a fresh install?

@johanneskastl
Copy link
Contributor Author

Updated the testing and documentation to include Fedora 37. However the checks seem to be failing on the installation step where the upgrade.sh netbox script is ran:

"Failed to build Pillow"

Are there any additional Python packages or steps for Fedora that need to be added to make this work on a fresh install?

I used the generic/fedora37 vagrant box and it worked with the changes from my PR. But as I am using some more roles before (to setup redis and postgresql) it might be that those are pulling in packages. I'll have a look.

@jvoss
Copy link
Owner

jvoss commented Apr 23, 2023

I wonder if it could be related to this thread: python-pillow fails to build with Python 3.11

If I follow correctly, they worked around it by using Python 3.10. I'm wondering what implications need to be considered if we set the Python version for Fedora 37 to 3.10 instead of 3.11. Thoughts?

@johanneskastl
Copy link
Contributor Author

If I follow correctly, they worked around it by using Python 3.10. I'm wondering what implications need to be considered if we set the Python version for Fedora 37 to 3.10 instead of 3.11. Thoughts?

Not sure why I do not see this on my local machine during testing.

But I just pushed a commit changing Fedora37 from python3.11 to python3.10, which also worked fine on my local machine. Let's see what the CI says...

@jvoss
Copy link
Owner

jvoss commented Apr 25, 2023

But I just pushed a commit changing Fedora37 from python3.11 to python3.10, which also worked fine on my local machine. Let's see what the CI says...

That seemed to do the trick. Anything else you think we should try or do you think this would suffice enough for merge?

@johanneskastl
Copy link
Contributor Author

That seemed to do the trick. Anything else you think we should try or do you think this would suffice enough for merge?

As it seems to work both locally and in the CI, I think we can safely merge it.

@jvoss jvoss merged commit 123850d into jvoss:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants