-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fedora37 #57
Add fedora37 #57
Conversation
Updated the testing and documentation to include Fedora 37. However the checks seem to be failing on the installation step where the
Are there any additional Python packages or steps for Fedora that need to be added to make this work on a fresh install? |
…_os_family RedHat, but has a different version number
I used the |
…ith a lowercase d)
I wonder if it could be related to this thread: python-pillow fails to build with Python 3.11 If I follow correctly, they worked around it by using Python 3.10. I'm wondering what implications need to be considered if we set the Python version for Fedora 37 to |
Not sure why I do not see this on my local machine during testing. But I just pushed a commit changing Fedora37 from python3.11 to python3.10, which also worked fine on my local machine. Let's see what the CI says... |
That seemed to do the trick. Anything else you think we should try or do you think this would suffice enough for merge? |
As it seems to work both locally and in the CI, I think we can safely merge it. |
Add Fedora37 variables and adjust loading of variables.
Loading the variables is not really nice, since the existing code uses
ansible_os_family == "RedHat"
, which also matches Fedora. If desired I could rework that to use e.g.first_found
or similar.