Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The recorded track is shorter than the original and/or having missing beats (faster than the original) #92

Closed
robert712002 opened this issue May 12, 2019 · 8 comments
Labels
bug 🐞 flagged 🚩 Cannot work on it at the moment
Milestone

Comments

@robert712002
Copy link

What is the bug ?

Sometimes, somewhere in the track, there is few milliseconds missing or skipping

How to reproduce it or what's the expected behavior ?

Just run the Spytify

@jwallet
Copy link
Owner

jwallet commented May 13, 2019

if you mean it misses a bit of the beginning or the ending, it's sadly... normal, spotify does not always provide the right info at the right time, resulting with a delay at the start or the end.

@robert712002
Copy link
Author

No, it's not that. I get a perfect start and end but in the middle, it can sometimes skip a beat.

Also not related, album art isn't getting downloaded, at all

@jwallet
Copy link
Owner

jwallet commented May 13, 2019

does the in-app f.a.q helps?

Background noise/sound was recorded on the saved track file [Second case]

@robert712002
Copy link
Author

Sorry for not replying, totally forgot to.
No I've tried muting everything manually, left the PC and it still did that

@jwallet
Copy link
Owner

jwallet commented Jun 5, 2019

@robert712002 sorry, i forgot to come back here, but by any chance, do you still have the recorded file that you can probably upload right here in this reply box, and the song on spotify
https://open.spotify.com/browse/featured

@robert712002
Copy link
Author

Here's one instance of it happening:
https://open.spotify.com/album/1V6fHc3rVOVvZqOgEkJCxT?si=6p6vqBdISMeU1bEeda1VqQ

Gopnik McBlyat - Supreme Memebass Gavno.zip

As you can see its 10 seconds shorter than on Spotify. Also, it didn't download the album art but you know about that issue already

@jwallet
Copy link
Owner

jwallet commented Aug 24, 2019

sorry for the delay, summer time.
i tried to record the song you were trying and got a perfect result. then, i compared yours to mine with audacity and like you said it skips some beats and end with a song 10 secs shorter. My guess is that your pc is not listening fast enough to the wav stream, so the writer misses some beats. like I said my guess is still cpu related, so if Spytify FAQ - Background noise - Second case - does not apply to you and you had your cpu in full capacity (no save mode) then try a different PC. You need something that does not go in saver mode (Power plan)
Gopnik McBlyat - Supreme Memebass Gavno.zip

turn on on windows 10 the Ultimate Power plan (hidden windows 10 feature)
https://www.auslogics.com/en/articles/turn-on-ultimate-performance-power-plan-win10/

you might want to check #103 to install a better driver for spytify.

@jwallet jwallet changed the title The recorded track is shorter than the original The recorded track is shorter than the original and/or having missing beats (faster than the original) Aug 24, 2019
@jwallet jwallet added the flagged 🚩 Cannot work on it at the moment label Aug 28, 2019
@jwallet
Copy link
Owner

jwallet commented Dec 14, 2019

I tried different settings to find the issue;
What I found using one computer is that in Power Saving Plan the recording gets shorter than the original. The .wav was recording fine, only the .mp3 had issue. So the issue comes from the third party package libmp3lame.
I will have a better look at the mp3 writer while the power saving mode is enabled

@jwallet jwallet self-assigned this Dec 14, 2019
jwallet added a commit that referenced this issue Jan 4, 2020
…ording

now able to record proper mp3 on power saver mode - close issue #92
jwallet added a commit that referenced this issue Jan 7, 2020
…ording

now able to record proper mp3 on power saver mode - close issue #92
related issue #102
jwallet added a commit that referenced this issue Jan 7, 2020
…ording

now able to record proper mp3 on power saver mode - 
close issue #92
related issue #102
@jwallet jwallet added this to the 1.5 milestone Jan 7, 2020
@jwallet jwallet mentioned this issue Jan 8, 2020
Merged
jwallet added a commit that referenced this issue Jan 8, 2020
- Output file to spytify to only transcode to mp3 at the end of the recording #92 #102 
- updated web site and readme to latest version, faq got removed from the app and is now on the site. #111 #103 
- extension for the recording file is now .spytify #117 
- fix recording timer feature to wait for track to end before ending the session. #114 
- removed hosts edit to disable ads, newer version of spotify are now incompatible with this hack.
- added timer for the track being recorded
- deleted tracks now appears in red into the console
- fixed spytify status when pausing spotify Free version
- updated depedencies, removed threads in favor of tasks and more fixes and optimization

close issue #92
close issue #111 
close issue #114
close issue #117 

related issue #102
related issue #103
@jwallet jwallet closed this as completed Jan 8, 2020
@jwallet jwallet removed their assignment Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 flagged 🚩 Cannot work on it at the moment
Projects
None yet
Development

No branches or pull requests

2 participants