Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing return in promise chain #171

Closed
getlarge opened this issue Aug 25, 2021 · 3 comments
Closed

fix: missing return in promise chain #171

getlarge opened this issue Aug 25, 2021 · 3 comments
Labels
released

Comments

@getlarge
Copy link

Hi,

I just came across that warning in a project :

Warning: a promise was created in a handler at ******/node_modules/amqp-connection-manager/dist/cjs/AmqpConnectionManager.js:207:22 but was not returned from it, see http://goo.gl/rRqMUw
    at Function.Promise.attempt.Promise.try (******/node_modules/bluebird/js/release/method.js:29:9)

I suppose that returning null in amqp.connect called here will solve the issue.
Should i create a PR ?
@jwalton
Copy link
Owner

jwalton commented Aug 25, 2021

I just removed that return null because I thought it wasn't doing anything. :P This is some Bluebird thing I take it?

Thanks for the heads up!

github-actions bot pushed a commit that referenced this issue Aug 25, 2021
@semantic-release-bot
chore(release): 3.4.3 [skip ci]
2b0bf0e 
## [3.4.3](v3.4.2...v3.4.3) (2021-08-25)

### Bug Fixes

* Fix bluebird warning. ([cb2f124](cb2f124)), closes [#171](#171)
jwalton pushed a commit that referenced this issue Aug 25, 2021
@semantic-release-bot @jwalton
chore(release): 3.4.3 [skip ci]
a54b5a5 
* Fix bluebird warning. ([cb2f124](cb2f124)), closes [#171](#171)
github-actions bot pushed a commit that referenced this issue Aug 25, 2021
@semantic-release-bot
chore(release): 3.4.3 [skip ci]
c27cfd4 
## [3.4.3](v3.4.2...v3.4.3) (2021-08-25)

### Bug Fixes

* **types:** 'options' should be optional in `connect()`. ([4619149](4619149))
* Fix bluebird warning. ([cb2f124](cb2f124)), closes [#171](#171)
@jwalton
Copy link
Owner

jwalton commented Aug 25, 2021

🎉 This issue has been resolved in version 3.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@getlarge
Copy link
Author

Thanks that was fast.
Yes that's a bluebird thing, still they are right that sometimes it's better to be explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwalton @getlarge