Proper way of handling errors in channel set up

[jonathanasquier]

Hello,
i've seen you've got an empty else statement with a comment // Don't emit an error if setups failed because the channel was closing..
I'm triggering a silent error when I'm trying to re-assert a queue with different arguments (ex: x-dead-letter-exchange)

when I add back the emit block

this.emit("error", err, {
   name: this.name
});

I can get my error

ERROR { Error: Operation failed: QueueDeclare; 406 (PRECONDITION-FAILED) with message "PRECONDITION_FAILED - inequivalent arg 'x-dead-letter-exchange' for queue 'my-queue' in vhost '/': received 'dl_4000' but current is 'dl_3000'"

by listening to the channel error event.
But I guest that was not meant to be done this way, so what would be a proper way of handling error channel setup functions ?

or maybe I'm supposed to catch the error in the disconnected event?

const amqp = require("..");

const connection = amqp.connect(["amqp://localhost"]);
connection.on("connect", function() {
  console.log("Connected!");
});

connection.on("disconnect", function(err) {
  console.log("Disconnected.", err); // got it
});

let channelWrapper = connection.createChannel({
  setup: function(channel) {
    return Promise.all([
      channel.assertQueue("queue_1", {
        durable: true,
        deadLetterExchange: "dl_1"
      })
    ]);
  }
});

channelWrapper.addSetup(channel => {
  return channel.assertQueue("queue_1", {
    deadLetterExchange: "dl_2"
  });
})

(PS: l'm building this https://github.com/trusk-official/amqp-connector and trying to add a deadletter feature!)

Thanks!

[jonathanasquier]

Closing because stale, i'm using connection.on("disconnect", function(err) {});

[jwalton]

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀