fix: error when unconfirmed message not found #166
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
An error is thrown when a message isn't found in _unconfirmedMessages. I don't have a working example of when it might happen, but when I tested around I could reproduce it with reconnects. This is in line with what michaelfitzhavey's team mates found.
Even if we are unsure how it happens, I think it is fair to say that it is better if it doesn't throw an error, since the error states that the message that we want to remove already is removed =)