Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation : Korean #397

Merged
merged 16 commits into from
Apr 17, 2019
Merged

Translation : Korean #397

merged 16 commits into from
Apr 17, 2019

Conversation

joonas-yoon
Copy link
Contributor

@joonas-yoon joonas-yoon commented Dec 1, 2018

New pull request and repo instead of Translation : Korean(#118) because linked repo in #118 is broken(or changed to private or deleted).

And issue is reopened. So, i made some stuffs and i will more.
also i have some important works for synchronizing with texts in current master branch.

If anyone who want to join, fork this repository please.

ans this comment for who can speak korean:
그리고 번역투를 자연스러운 한국어 문장으로 변경하는 것에 대해 의견을 구하고 싶습니다.
ex) 행운을 빈다! -> 행운을 빕니다!

@joonas-yoon
Copy link
Contributor Author

I'm using diff tool to sync files by mergely.com. I hope it helps you.

@jwasham
Copy link
Owner

jwasham commented Dec 2, 2018

Thank you!

@joonas-yoon
Copy link
Contributor Author

You can merge this PL, but I hope it will not to be closed.

@jwasham jwasham merged commit 120b76f into jwasham:master Apr 17, 2019
@jwasham
Copy link
Owner

jwasham commented Apr 17, 2019

Thank you. Well, it closed the pull request, but you can open another. I don't think I can reopen it now that it's merged.

codecalligrapher pushed a commit to codecalligrapher/coding-interview-university that referenced this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants