Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't Merge yet] Spanish Translation in progress #78

Merged
merged 111 commits into from
May 28, 2017

Conversation

dossorio
Copy link
Contributor

@dossorio dossorio commented Dec 20, 2016

Description

Spanish translation of google-interview-university

This is a work in progress ! Feel free to collaborate!

  1. Pick an issue from https://github.com/dossorio/google-interview-university/issues
  2. Fork https://github.com/dossorio/google-interview-university and translate your chunk in translations/README-es.md
  3. Open a pr with master of this repo as base for your pr and contribute ! Thank you so much !! :)

All commits will be squashed into one big Spanish Translation before merging, so don't worry about them! just translate ! 👍

@dossorio dossorio mentioned this pull request Dec 20, 2016
dossorio and others added 2 commits December 21, 2016 19:21
Y just don know how to translate stack and heap to Spanish
README-es.md Outdated

Es mi guía de estudio en varios meses para ir de desarrollador web (Autodidacta, sin grado en Ciencias de Computadores) a ingeniero de software en Google.
Es mi guía de estudio en varios meses para ir de desarrollador web (Autodidacta, sin grado en Ciencias de Computadores)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que "Ciencias de la computación" es el termino estandar en lugar de "Ciencias de Computadoras"

@ghost
Copy link

ghost commented Dec 21, 2016

I'm going to add some comments about the current translation, just some little suggestions!

README-es.md Outdated
There are extra items I added at the bottom that may come up in the interview or be helpful in solving a problem. Many items are from
Steve Yegge's "[Get that job at Google](http://steve-yegge.blogspot.com/2008/03/get-that-job-at-google.html)" and are reflected
sometimes word-for-word in Google's coaching notes.
Esta lista tan larga, ha sido extraída y ampliada de las **Google's coaching notes**, asi que estas son las cosas que
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Esta lista tan larga" → "Esta larga lista"

@jwasham
Copy link
Owner

jwasham commented Dec 29, 2016

Please move your translation file to the translations directory. Thank you!

Rodolfo Rodriguez and others added 2 commits December 30, 2016 18:01
@dossorio dossorio mentioned this pull request Jan 2, 2017
README-es.md Outdated

I'd appreciate your help to add free and always-available public sources, such as YouTube videos to accompany the online course videos.
I like using university lectures.
Agradecería tu ayuda para añadir recursos públicos gratis, que siempre estuvieran disponibles, como video s de YouTube
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agradecería tu ayuda para añadir recursos públicos gratis, que siempre estuvieran disponibles, como videos de YouTube

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot !! Thanks !!

Copy link
Contributor Author

@dossorio dossorio Jan 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here dossorio@a749ece @MiguelMB ! Thanks very much !

Feel free to pick any issue and start translating ! 👍

Cheers !

README-es.md Outdated
- [ ] [Cracking the Coding Interview con el autor Gayle Laakmann McDowell (video)](https://www.youtube.com/watch?v=aClxtDcdpsQ)
- [ ] Como conseguir un trabajo en una de las 4 grandes:
- [ ] ['Como conseguir un trabajo en una de las 4 grandes - Amazon, Facebook, Google & Microsoft' (video)](https://www.youtube.com/watch?v=YJZCUhxNCv8)
- [ ] [Haciendo las entrevistas de Google mal](http://alexbowe.com/failing-at-google-interviews/)

## Pick One Language for the Interview
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escoge un lenguaje de programacion para la entrevista

@esaucedof
Copy link
Contributor

I think is ready for the merge.
If someone can make a review please do it. :)

Copy link
Contributor Author

@dossorio dossorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job mate ! 👍

I found some small things and that the translation files were renamed from using a hyphen to use underscore, we should fix that before merging

Let me know if you want me to fix them, again brilliant job @YoSaucedo !! Thanks !!!

Apart from the ones you see in the comments, I found (I had to add this list in this way because it seems that github is buggy when showing comments when there are lots of changes):

  • translations/README_es.md:1436 We are missing the Una vez obtenido el empleo title
  • translations/README_es.md:1569 We could translate Garbage Collection to Recolección de basura what do you think ?
  • translations/README_es.md:1576 We need an extra line break before - [ ] [Coursera (Scala)]
  • translations/README_es.md:1695 curioso

README.md Outdated
@@ -1607,9 +1608,6 @@ software engineer, and to be aware of certain technologies and algorithms, so yo
- [ ] [Deep Dive Python: Garbage Collection in CPython (video)](https://www.youtube.com/watch?v=P-8Z0-MhdQs&list=PLdzf4Clw0VbOEWOS_sLhT_9zaiQDrS5AR&index=3)

- ### Parallel Programming
- [ ] [Coursera (Scala)](https://www.coursera.org/learn/parprog1/home/week/1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were this two links meant to be removed ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one. Done


Estoy usando el tema especial de markdown de Github, incluyendo listas de tareas para comprobar el progreso.

[] **Cree una nueva rama para que pueda validar elementos como este, solo ponga una x en los corchetes: [x]**
Copy link
Contributor Author

@dossorio dossorio May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove these square brackets ([] **Cree)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have erased the brackets

Algunos videos solo están disponibles inscribiéndose a una clase de Coursera, EdX, o Lynda.com. Estos son llamados MOOCs.
En ocasiones las clases no están en sesión por lo que tendrá que esperar un par de meses, por lo que no tiene acceso. Los cursos de Lynda.com no son gratuitos.

Apreciaría su ayuda añadiendo fuentes siempre disponibles, publicas y gratuitas como videos de Youtube para acompañar a los videos del curso en línea.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph needs to match the indentation of the next one to be in the same grey box

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now they have the same indentation.

- [ ] Cuenta los componentes conectados en un grafo
- [ ] Lista de componentes fuertemente conectados
- [ ] Verificación de grafo bipartito
Obtendrá más práctica de grafos en el libro de Skiena (vea Sección de libros debajo) y en los libros de entrevistas
Copy link
Contributor Author

@dossorio dossorio May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an extra line break before Obtendrá, so it doesn't get mixed with the previous bullet point

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space added.

- [Criptografía](#criptografía)
- [Compresión](#compresión)
- [Seguridad informática](#seguridad-informática)
- [Garbage collection](#garbage-collection)
Copy link
Contributor Author

@dossorio dossorio May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could translate this title to Recolección de basura what do you think ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted and Done.

@dossorio
Copy link
Contributor Author

Hi guys !

LGTM ! if you are all happy too, I think is ready to merge 👍

English is key in Software Engineering, but I think bringing this list to our Spanish speaking community is really positive and a starting point for those who want to improve and be better 😃

Thanks very much to all those who contributed !! and @jwasham for creating it and spreading the word of what a competent Software Engineer should be

Cheers all !

@jwasham jwasham merged commit 1762907 into jwasham:master May 28, 2017
@jwasham
Copy link
Owner

jwasham commented May 28, 2017

Many thanks to all of you for your contributions, and @dossorio for managing this long-running pull request. I greatly appreciate all your contributions that will help many!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants