Skip LXC hidden dir in /dev when looking for TTYs #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LXC containers, /dev/.lxc contains subdirs for the sys and proc fs to be mounted into the container. These files are not readable directly, Proc::ProcessTable::_get_tty_list attempts to stat the files in these directories which results in a lot of warnings. There aren't going to be any TTY device files there so skip the whole dir.
|
awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LXC containers, /dev/.lxc contains subdirs for the sys and proc fs to be mounted into the container. These files are not readable directly, Proc::ProcessTable::_get_tty_list attempts to stat the files in these directories which results in a lot of warnings. There aren't going to be any TTY device files there so you can skip the whole dir.
For an example of this causing issues, see liske/needrestart#170 .