Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renders return an undefined element #19

Closed
wibus-wee opened this issue Dec 22, 2022 · 0 comments · Fixed by #20
Closed

Renders return an undefined element #19

wibus-wee opened this issue Dec 22, 2022 · 0 comments · Fixed by #20
Labels
bug Something isn't working high-level High risk, high error, etc. module/core

Comments

@wibus-wee
Copy link
Member

Description

After element render, it return a element tagName called "undefined".

This seems to be a result of not executing 'map', even console.log printing index in the map didn't return anything

Reproduction

https://github.com/wibus-wee/wc-lantern/blob/main/src/index.tsx#L63-L89

Screenshot

截屏2022-12-22 18 10 13
@wibus-wee wibus-wee added the bug Something isn't working label Dec 22, 2022
@wibus-wee wibus-wee changed the title render return an undefined element Renders return an undefined element Dec 22, 2022
@wibus-wee wibus-wee added module/core high-level High risk, high error, etc. labels Dec 22, 2022
@wibus-wee wibus-wee mentioned this issue Dec 22, 2022
Merged
wibus-wee added a commit that referenced this issue Dec 22, 2022
@wibus-wee
fix(core): missing checking vnode type in creating, fixed #19 (#20)
6e25dc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high-level High risk, high error, etc. module/core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): missing checking vnode type in creating, fixed #19 jwcjs/core
1 participant
@wibus-wee