Use pip to install a not necessarily fully compatible flask. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #72 this was suggested by @ValentinFrancois because as they pointed out, the current version doesn't seem to actually install the right flask versions. However, they used
poetry addto install the required version for testing. It appears, if you try to add a version of (for example) Flask, which is not available for all the Python versions that the package supports, poetry will complain and refuse: python-poetry/poetry#697Attempting to do this with pip in the hope that it allows us to correctly test the python/flask combinations.