Preserve value of async-prompt-for-password when async-start is called #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows callers of async-start to let-bind async-prompt-for-password (e.g., to nil to prevent any prompting on data that might contain arbitrary sexps). The value in effect while async-start is called is saved in the process's buffer, and is therefore used by async-read-from-client since it makes the process's buffer current.
This was referenced Dec 16, 2023
thierryvolpiatto
added a commit
that referenced
this pull request
Dec 22, 2023
To do this, we use a local lexical var bound to async-prompt-for-password and pass the value of this var through a closure used as process filter.
|
Thanks, closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows callers of async-start to let-bind
async-prompt-for-password (e.g., to nil to prevent any prompting on data that might contain arbitrary sexps). The value in effect while async-start is called is saved in the process's buffer, and is therefore used by async-read-from-client since it makes the process's buffer current.