Image on private registries #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- more flexible shebang - restart haproxy directly rather than using shell script - check that haproxy is installed and on the PATH before running - more docs - connect to etcd once - created main() function - simplified main procedure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of my other pull request, this one addresses the use of images that reside in private registries.
Normally, the image will look like
repo/image. In the case of an image on a private registry, the domain/IP (and maybe port) is also included in the image name, looking more likedomain.com/repo/imageor1.2.3.4:5678/repo/image.When your docker-register project places information for these images into etcd, they go into a key that looks like
/backends/repo/image/imgid. This change will pull just the last two slash-separated bits of the key, handling both public and private images.