Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osx delete key doesnt work #27

Closed
drewwebster opened this issue Feb 25, 2020 · 4 comments
Closed

osx delete key doesnt work #27

drewwebster opened this issue Feb 25, 2020 · 4 comments
Labels
Bug Something isn't working Core Add for issues having to do with core functions Help wanted Extra attention is needed
Milestone

Comments

@drewwebster
Copy link

on macbook pro delete key doesnt work on all examples.

in autogit.py it appends ?^? to text entered in input box

i suspect its the ascii key code with curses.
i tried code 8 - that is ascii key code for delete key on mac (?)

found this curses code, but not with solution

https://www.programcreek.com/python/example/21642/curses.KEY_DC

@drewwebster
Copy link
Author

drewwebster commented Feb 25, 2020

okay i found a fix. now i can type in textbox and use delete key

in keys.py i changed to:

# Pressing backspace returns 8 on windows?
if platform == 'win32':
    KEY_BACKSPACE   = 8
elif platform == 'darwin':
    KEY_BACKSPACE = 127
else:
    KEY_BACKSPACE   = curses.KEY_BACKSPACE

@jwlodek
Copy link
Owner

jwlodek commented Feb 25, 2020

Could you make a pull request with that fix? I don't have access to a MacOS machine, so I wasn't able to test on that platform. I imagine that the KEY_DELETE key code is also invalid on MacOS, and should be fixed.

@jwlodek jwlodek added Bug Something isn't working Core Add for issues having to do with core functions labels Feb 25, 2020
@jwlodek jwlodek added this to the v0.1.0 milestone Feb 27, 2020
@drewwebster
Copy link
Author

ok will do

@jwlodek jwlodek added the Help wanted Extra attention is needed label Mar 11, 2020
jwlodek pushed a commit that referenced this issue Apr 3, 2020
@jwlodek jwlodek mentioned this issue Apr 12, 2020
3 tasks
@jwlodek
Copy link
Owner

jwlodek commented Apr 18, 2020

Closing, resolved with v0.1.0

@jwlodek jwlodek closed this as completed Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Add for issues having to do with core functions Help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants