-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 Formatting #157
PEP8 Formatting #157
Conversation
This looks good, maybe only suggestion would be bump the line length a bit? Maybe to ~95? I have a preference for longer lines where possible. If you could adjust for that and fix the newly found conflicts I'll approve and merge. |
So I tried to increase the line length with def some_func():
pass became: def some_func(
):
pass Which is just useless and ugly. So I came back to |
I believe the current conflict is caused by some changes I've made on the branch since this PR was opened, may want to pull those changes and try re-running the formatting? |
I copy/pasted the current |
Ok, I just deleted that empty line from GitHub it must be good for merge. |
Ok, I think it looks fine to me, maybe would want to replace the default |
I just made a test, to see what auto formatting tool could best fit the project.
So, in order to keep docstrings intact we cannot use
black
. That leaves us withautopep8
andyapf
, I guessautopep8
could do the job.I tested it on
__init__.py
as a demo because it's a pretty big piece.Configuration is vanilla except for max line length, I set it to 88 as
black
does, we could set another value.Tell me if the file looks good to you @jwlodek, or if something seems odd.
In my opinion the code already looks nicer, more consistent.