Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename-unsafe-lifecycles #78

Closed
wants to merge 1 commit into from
Closed

rename-unsafe-lifecycles #78

wants to merge 1 commit into from

Conversation

dthuering
Copy link

Did run npx react-codemod rename-unsafe-lifecycles to rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps.
Fixes #77

Ashoat
Ashoat requested changes Dec 29, 2019
View reviewed changes
Copy link
Collaborator

@Ashoat Ashoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dthuering. I think we should take this moment to actually try and update the lifecycle methods instead of just renaming to UNSAFE_ to silence the errors.

I maintain a forked version of this component in my own project which I have updated to use componentDidUpdate and getDerivedStateFromProps. You can hopefully look at the changes I made there and mirror them back.

@dthuering dthuering closed this Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashoat Ashoat Ashoat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings after updating to RN 0.61
2 participants
@dthuering @Ashoat