PBS Bid Adapter: alias Fix (prebid#9100)

* Added adjustment for aliasing unregistered bidders for server-side * removed import
jwplayer · May 18, 2023 · a9b1916 · a9b1916
1 parent 0dc1518
commit a9b1916
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/modules/prebidServerBidAdapter/index.js b/modules/prebidServerBidAdapter/index.js
@@ -558,7 +558,7 @@ Object.assign(ORTB2.prototype, {
           const bidder = adapterManager.bidderRegistry[bid.bidder];
           // adding alias only if alias source bidder exists and alias isn't configured to be standalone
           // pbs adapter
-          if (bidder && !bidder.getSpec().skipPbsAliasing) {
+          if (!bidder || !bidder.getSpec().skipPbsAliasing) {
             aliases[bid.bidder] = adapterManager.aliasRegistry[bid.bidder];
           }
         }

diff --git a/test/spec/modules/prebidServerBidAdapter_spec.js b/test/spec/modules/prebidServerBidAdapter_spec.js
@@ -1466,6 +1466,30 @@ describe('S2S Adapter', function () {
       });
     });
 
+    it('unregistered bidder should alias', function () {
+      const adjustedConfig = utils.deepClone(CONFIG);
+      adjustedConfig.bidders = 'bidderD'
+      config.setConfig({ s2sConfig: adjustedConfig });
+
+      const aliasBidder = {
+        bidder: 'bidderD',
+        params: {
+          unit: '10433394',
+        }
+      };
+
+      $$PREBID_GLOBAL$$.aliasBidder('mockBidder', aliasBidder.bidder);
+
+      const request = utils.deepClone(REQUEST);
+      request.ad_units[0].bids = [aliasBidder];
+      request.s2sConfig = adjustedConfig;
+
+      adapter.callBids(request, BID_REQUESTS, addBidResponse, done, ajax);
+
+      const requestBid = JSON.parse(server.requests[0].requestBody);
+      expect(requestBid.ext.prebid.aliases).to.deep.equal({ bidderD: 'mockBidder' });
+    });
+
     it('adds dynamic aliases to request', function () {
       config.setConfig({ s2sConfig: CONFIG });