Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AD -775][JW8-11235] JWPlayer Targeting module #3
[AD -775][JW8-11235] JWPlayer Targeting module #3
Changes from all commits
38bf558
432122a
599a243
410f963
0003a3d
18f83cc
7a76ea6
130aa2a
01f2f18
a54c567
0293d2d
1789d8d
79b7b84
296a6cb
eb132fa
ddf873f
40fd468
7fcfcd1
49e983d
5cada07
2ee0d2f
c1ef816
87796fd
dde5ff0
61cf182
5ab3c78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added this a few weeks ago for SpotX to track that the ad is coming from our VPB. Are you sure we want to remove this?
CC: @mamaddox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question. Here is a ticket I created about it: https://jwplayer.atlassian.net/browse/JW8-11226
Now I don't know too much about this parameter, but I know it was added here after the Prebid migration as a workaround for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamaddox Was this merged upstream ? I saw it was failing SpotX's unit tests. I'll take a look again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karimMourra It's not merged upstream because it doesn't and has never existed there. Probably why the tests are failing.
From what I could gather, it's a parameter that we have always implemented on our side. Before migrating to open source Prebid, we used
player_vendor
to track the SpotX ads through our own VPB solution. Once we migrated to Prebid, the param was only added back to our fork as a workaround I'm assuming. I didn't see any other Prebid adapters using a param like this and SpotX never used it in their adapter, so I'm assuming that's why the change was never merged upstream. I don't know much about it though tbh.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok now I see. So @mamaddox is VPB using our fork of Prebid.js ?
Adding
player_vendor: 'SpotXJW'
to spotX's adapter is definitely wrong so i doubt it would be accepted upstream. We probably shouldn't be modifying a vendor's adapter.If our current build of VPB needs
player_vendor: 'SpotXJW'
then i'm ok with not merging my branch to our fork, and opening a PR directly with Prebid.js upstream once this PR is approved.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karimMourra We do use our fork of Prebid. We are currently pointing to the
spotx-min-max-duration
branch.https://github.com/jwplayer/jwplayer-ads-header-bidding/blob/92530d12ca9b0046be466cf1489028421e1a33b9/package.json#L63-L65
You could merge this into our fork since we are using that branch, but I think we would still be in the same situation we've been in regarding this
player_vendor
param. I tried to spell out everything I knew and could find about the param in that JIRA ticket.I do agree though that we probably shouldn't just be modifying the adapter on our end.