Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADHOC: clean up a bad merge causing Android build bug #28

Merged
merged 1 commit into from
May 16, 2024
Merged

ADHOC: clean up a bad merge causing Android build bug #28

merged 1 commit into from
May 16, 2024

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Put the instantiation of a variable before it's usage

Why is this Pull Request needed?

  • Broken Android building

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

N/A: Non-issue bug fix

@Jmilham21 Jmilham21 requested a review from a team as a code owner May 16, 2024 14:06
AmitaiB
AmitaiB approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@AmitaiB AmitaiB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange how the IDE didn't catch this? 👍

Edit: I see, it's in the name: merge hell :)

@Jmilham21 Jmilham21 merged commit 342d473 into master May 16, 2024
@Jmilham21 Jmilham21 deleted the fix/bad-isdefault-logic branch May 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitaiB AmitaiB AmitaiB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jmilham21 @AmitaiB