Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: badge-maker as dev dep #38

Merged

Conversation

chriszs
Copy link
Contributor

@chriszs chriszs commented May 23, 2024

What does this Pull Request do?

Makes badge-maker a dev dependency.

Why is this Pull Request needed?

Reduces the number of dependencies added when installing the library.

Addresses Issue(s):

GitHub Issue

@chriszs chriszs requested a review from a team as a code owner May 23, 2024 12:53
Copy link
Contributor

@AmitaiB AmitaiB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Copy link
Collaborator

@Jmilham21 Jmilham21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jmilham21 Jmilham21 merged commit 415d52c into jwplayer:master May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants