Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PiP receiver. Refactor Example to better implement PiP. Fix view display issue in PiP #66

Merged

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Enhance PiP implementation
  • Fix Toolbar displaying in PiP issue in Example
  • Slightly resolve the PiP issue where player isn't centered

Why is this Pull Request needed?

  • PiP on Android isn't working well
  • Example app wasn't setup well for PiP

Are there any points in the code the reviewer needs to double check?

  • Test implementation with the following config
  let jwConfig = {
    "title": "Single Inline Linear Preroll",
    "playlist": [
      {
        "title": "Single Inline Linear Preroll",
        "file": "https://content.bitsontherun.com/videos/q1fx20VZ-52qL9xLP.mp4"
      }
    ],
    "pipEnabled":true
  }
  • Hiccup when switching into PiP... React Native seems to want to reshow the toolbar so I had to take some workaround steps to ensure the Player is rendered in frame of PiP.

Are there any Pull Requests open in other repos which need to be merged with this?

  • No

Addresses Issue(s):

  • Internal JWP ticket

@Jmilham21 Jmilham21 requested a review from a team as a code owner August 1, 2024 18:28
Copy link

@david-almaguer david-almaguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me 👍

@Jmilham21 Jmilham21 merged commit 4c8d9d8 into master Aug 6, 2024
@Jmilham21 Jmilham21 deleted the bug/SDK-11453-pip-player-not-displaying-correctly branch August 6, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants