Fix / add array at polyfill #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
AntonLantukh and
dbudzins
as code owners
|
Visit the preview URL for this PR (updated for commit fa3e77c): https://ottwebapp--pr660-fix-add-array-at-pol-597oa4td.web.app (expires Wed, 15 Jan 2025 16:32:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
royschut
approved these changes
Dec 17, 2024
AntonLantukh
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the maintenance update #656, the marked package was updated. While testing this on TV platforms or older Android devices, we ran into a crash caused by this upgrade. The crash was caused by marked using
Array#atwhich isn't transpiled for browser usage.The easiest fix was to add the polyfill...