Adding IAlgFactory to master (v3) branch #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding IAlgorithmFactory by default implemented by AlgorithmFactory. Using IAlgorithmFactory in JwtDecoder * Renaming AlgorithmFactory to HMACSHAAlgorithmFactory * Adding RSAlgorithmFactory inheriting HMACSHAAlgorithmFactory * Adding DotSettings with abbreviations
|
@abatishchev the current stable Nuget version |
|
Oh, really? How could it happen? Hmm. I'll replace it tomorrow with the right assembly. Sorry about this. |
|
@blgrnboy Thanks for reviewing! I tried to check-in but GitHub settings if require a review than require by a member (@nbarbettini). Let's wait him to come back and review, I'll check-in shortly thereafter. |
abatishchev
force-pushed
the
IAlgFactory-v3
branch
from
4d8e911 to
095627a
Compare
|
Thank you for your quick responses.
…On May 2, 2017 1:11 PM, "Alexander Batishchev" ***@***.***> wrote:
@djavier <https://github.com/djavier> this has been fixed, 2.4.1
<https://www.nuget.org/packages/JWT/2.4.1> is release, 2.4.0 is unlisted.
Thanks for reporting!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#102 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABlgPns5lDNSYlGqb86x24h6EIyuD74Zks5r12O1gaJpZM4NNQmn>
.
|
|
Meanwhile I published this as 3.0.0-beta2 |
|
@nbarbettini hey Nate, please take a look to let it in. |
nbarbettini
approved these changes
May 13, 2017
|
Looks good 👍 sorry for the delay @abatishchev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying changes from #101