Making JwtEncoder.Validate() public

[abatishchev]

Resolves #126

[abatishchev]

@nskhara please validate whether it'd work for you

[nbarbettini]

No issues, but it seems like an odd method to make public. As discussed in the issue, the IJwtValidator is a better interface for this (that already exists), and the signature of this method is not really nice for consumption (it's just an internal method). Seems like it'd be cleaner to just use the IJwtValidator interface.

[abatishchev]

My doubt is IValidator becomes very coupled with IDecoder. But I think it's fine. Shall we rework the interface (make public method private and private method public)?

[nbarbettini]

I'm not quite following what you mean - but I'm happy to review a PR. 😃

[nskhara]

@abatishchev
Thank you for the change.

One thing, would it be nice if you could add the method into the IJwtDecoder interface also?
(So you can access it through the interface)

IJwtDecoder decoder = new JwtDecoder(blah, blah, ...);
// some other processess...
decoder.Validate(blah, blah,...);

[abatishchev]

Yes, that's what we've discussed above and I'll address once AppVeyor is functional again. Later this week for sure since I already started.

[abatishchev]

Unfortunately I didn't find this feasible to move this Validate() method to Validator. I refactored it thought to simplify the signature. Please try yourself or/and let me know if it's fine to merge it as it is for now

[abatishchev]

Shall I check this in?

[nskhara]

thank you, abatishchev :-)