Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing Json.Net 9.0.1, fixing output folder settings, bumping version to 3.0.3 #133

Merged
merged 8 commits into from
Aug 18, 2017

Conversation

abatishchev
Copy link
Member

@abatishchev abatishchev commented Aug 18, 2017

  • Referencing Json.Net 9.0.1
  • Fixing output folder settings
  • Bumping version to 3.0.3

@abatishchev abatishchev self-assigned this Aug 18, 2017
@abatishchev abatishchev added this to the 3.0 milestone Aug 18, 2017
@abatishchev
Copy link
Member Author

@nbarbettini sorry, I messed nuget version up, used 3.10 instead of 3.1.0. Please approve once again.

@abatishchev abatishchev changed the title Targeting .NET 4.5.2, referencing Json.Net 9.0.1+ core (redo) Targeting .NET 4.5.2, referencing Json.Net 9.0.1+ (redo) Aug 18, 2017
@abatishchev
Copy link
Member Author

We've messed everything up! We can't target 45x because RSA doesn't have method SignData(Byte[], HashAlgorithmName, RSASignaturePadding), it was added only only in 46x

@abatishchev abatishchev changed the title Targeting .NET 4.5.2, referencing Json.Net 9.0.1+ (redo) Fix output folder settings, bump version to 3.0.3 Aug 18, 2017
@abatishchev abatishchev changed the title Fix output folder settings, bump version to 3.0.3 Referencing Json.Net 9.0.1, fixing output folder settings, bumping version to 3.0.3 Aug 18, 2017
@abatishchev
Copy link
Member Author

@nbarbettini can you please take a look to the changers in `? I tried to normalize it across build configuration and target platform.

@nbarbettini
Copy link
Contributor

LGTM

@abatishchev abatishchev merged commit 66c6344 into master Aug 18, 2017
@abatishchev abatishchev deleted the net452 branch August 18, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants